linux-kernel - Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171011113107.Horde.iB4g8uGTQZ4zFqy_7M5EF95@gator4166.hostgator.com>
Date:   Wed, 11 Oct 2017 11:31:07 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: mark expected switch fall-through in
 check_urb_status


Quoting Johan Hovold <johan@...nel.org>:

> On Wed, Oct 11, 2017 at 10:12:50AM -0500, Gustavo A. R. Silva wrote:
>> Hi Johan,
>>
>> Quoting Johan Hovold <johan@...nel.org>:
>
>> > Patch is fine, but next time make sure to run scripts/get_maintainer.sh
>> > to figure which people and lists to CC.
>> >
>>
>> I actually did:
>>
>> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
>> drivers/staging/greybus/es2.c
>>
>> and this was the output:
>>
>> linux-kernel@...r.kernel.org (open list)
>
> Very odd. If I run the exact same command I get the expected result:
>
> Johan Hovold <johan@...nel.org> (maintainer:GREYBUS SUBSYSTEM)
> Alex Elder <elder@...nel.org> (maintainer:GREYBUS SUBSYSTEM)
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> (maintainer:GREYBUS  
> SUBSYSTEM)
> greybus-dev@...ts.linaro.org (moderated list:GREYBUS SUBSYSTEM)
> devel@...verdev.osuosl.org (open list:STAGING SUBSYSTEM)
> linux-kernel@...r.kernel.org (open list)
>

I double checked and this is what happened:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers//staging/greybus/es2.c

Notice that double slash after drivers: //

For some reason I was running that command instead of this one:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers/staging/greybus/es2.c

>> > We also try to include the module (component) "es2" in the commit
>> > summary (unless you really are doing things subsystem wide), although
>> > that has not been enforced for staging clean ups recently.
>> >
>>
>> I got it. I'll take that into account for future patches.
>
> Looking at the commit history for the file in questions usually gives a
> hint about the style used for the corresponding subsystem.
>

Yep, I usually do that:

$ git log --oneline drivers/staging/greybus/es2.c

This time I got many of these two:

staging: greybus:
greybus: es2:

so I picked up the first one.

But I get your point and I understand now that I should have used the  
second one.

Thanks
--
Gustavo A. R. Silva