linux-kernel - Re: [PATCH 2/2] Bluetooth: BT_HCIUART now depends on SERIAL_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <C156D266-F58A-4A4E-986E-17B003BE5A37@holtmann.org>
Date:   Wed, 11 Oct 2017 20:10:54 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Sebastian Reichel <sre@...nel.org>,
        Tobias Regnery <tobias.regnery@...il.com>,
        "bluez mailin list (linux-bluetooth@...r.kernel.org)" 
        <linux-bluetooth@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: BT_HCIUART now depends on SERIAL_DEV_BUS

Hi Hans,

>> It is no longer possible to build BT_HCIUART into the kernel
>> when SERIAL_DEV_BUS is a loadable module, even if none of the
>> SERIAL_DEV_BUS based implementations are selected:
>> drivers/bluetooth/hci_ldisc.o: In function `hci_uart_set_flow_control':
>> hci_ldisc.c:(.text+0xb40): undefined reference to `serdev_device_set_flow_control'
>> hci_ldisc.c:(.text+0xb5c): undefined reference to `serdev_device_set_tiocm'
>> This adds a dependency to avoid the broken configuration.
>> Fixes: 7841d554809b ("Bluetooth: hci_uart_set_flow_control: Fix NULL deref when using serdev")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Another one I have on my TODO after the buildbot errors. In this case
> I do not believe this is the proper fix though.
> 
> As pointed out in another thread discussing the series introducing
> this problem, hci_ldisc.c really should not depend on serdev,
> so the proper fix would be to have hci_bcm.c directly call
> the serdev flowcontrol and rts functions when the hci is
> backed by a serdev device, like hci_bcm.c is already doing
> when setting the baudrate, see host_set_baudrate in hci_bcm.c,
> so a similar host_set_flow_control should be added after which
> the changes to hci_ldisc.c can be reverted.
> 
> If I understood Marcel correctly he prefers a single patch
> fixing this which also removes the changes from hci_ldisc.c,
> rather then a separate revert.

actually two patches is fine, but I want them as a patch series so they are applied in a row. I think best is first to revert the btusb.c changes and then apply the new ACPI PNP id.

Regards

Marcel