linux-kernel - Re: [PATCH 4.4 32/53] cifs: return ENAMETOOLONG for overlong names in cifs_open()/cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1507749850.6777.4.camel@codethink.co.uk>
Date:   Wed, 11 Oct 2017 20:24:10 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Ronnie Sahlberg <lsahlber@...hat.com>,
        Steve French <smfrench@...il.com>
Cc:     stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4.4 32/53] cifs: return ENAMETOOLONG for overlong names
 in cifs_open()/cifs_lookup()

On Mon, 2017-08-28 at 10:05 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Ronnie Sahlberg <lsahlber@...hat.com>
> 
> commit d3edede29f74d335f81d95a4588f5f136a9f7dcf upstream.
[...]
> @@ -505,6 +506,11 @@ cifs_atomic_open(struct inode *inode, st
>  	}
>  
>  	tcon = tlink_tcon(tlink);
> +
> +	rc = check_name(direntry, tcon);
> +	if (rc)
> +		goto out_free_xid;
> +
>  	server = tcon->ses->server;
>  
>  	if (server->ops->new_lease_key)
[...]

Doesn't this leak a reference to tlink?  Seems like the exit label
should be 'out' not 'out_free_xid'.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.