linux-kernel - Re: [PATCH] m68k: pull mach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWwZ0d25bYuneqa_1uFuQ2Zjsrfvbr28uGTpA0fESGFHQ@mail.gmail.com>
Date:   Thu, 12 Oct 2017 08:35:17 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Greg Ungerer <gerg@...ux-m68k.org>
Cc:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k: pull mach_beep in setup.c

Hi Greg,

On Thu, Oct 12, 2017 at 2:15 AM, Greg Ungerer <gerg@...ux-m68k.org> wrote:
> On 28/09/17 19:44, Alexandre Belloni wrote:
>> It is possible to select INPUT_M68K_BEEP in a nommu configuration. This
>> results in the following link error:
>>
>> drivers/input/misc/m68kspkr.o: In function `m68kspkr_event':
>> m68kspkr.c:(.text+0x3a): undefined reference to `mach_beep'
>> m68kspkr.c:(.text+0x5e): undefined reference to `mach_beep'
>> m68kspkr.c:(.text+0x78): undefined reference to `mach_beep'
>> drivers/input/misc/m68kspkr.o: In function `m68kspkr_init':
>> m68kspkr.c:(.init.text+0x4): undefined reference to `mach_beep'
>>
>> Pull the mach_beep definition in setup.c to avoid it.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
>
> I plan on applying this to the m68knommu git tree (for-next) branch
> in the very near future.
>
> Geert: no objections?

No objections:
Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds