linux-kernel - Re: [RESEND PATCH v11 0/2] Make find_later

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171012080005.GM3323@X58A-UD3R>
Date:   Thu, 12 Oct 2017 17:00:06 +0900
From:   Byungchul Park <byungchul.park@....com>
To:     peterz@...radead.org, mingo@...nel.org, rostedt@...dmis.org
Cc:     linux-kernel@...r.kernel.org, juri.lelli@...il.com,
        kernel-team@....com
Subject: Re: [RESEND PATCH v11 0/2] Make find_later_rq() choose a closer cpu
 in topology

On Tue, Oct 10, 2017 at 03:37:52PM +0900, Byungchul Park wrote:

Any problem with this? Peter, you suggested and I implemented it.
Did I do in a wrong way?

> Change from v10
>    -. modify a comment a bit as Steven suggested
> 
> Change from v9
>    -. modify a comment a bit so to be more clear as Juri suggested
> 
> Change from v8
>    -. add suggested-by Peterz
>    -. add several comments
> 
> Change from v7
>    -. fix a trivial typo
>    -. modify commit messages to explain what it does more clearly
>    -. simplify code with an existing macro
> 
> Change from v6
>    -. add a comment about selection of fallback_cpu incase more than one exist
>    -. modify a comment explaining what we do wrt PREFER_SIBLING
> 
> Change from v5
>    -. exclude two patches already picked up by peterz
>       (sched/deadline: Make find_later_rq() choose a closer cpu in topology)
>       (sched/deadline: Change return value of cpudl_find())
>    -. apply what peterz fixed for 'prefer sibling', into deadline and rt
> 
> Change from v4
>    -. remove a patch that might cause huge lock contention
>       (by spin lock(&cpudl.lock) in a hot path of scheduler)
> 
> Change from v3
>    -. rename closest_cpu to best_cpu so that it align with rt
>    -. protect referring cpudl.elements with cpudl.lock
>    -. change return value of cpudl_find() to bool
> 
> Change from v2
>    -. add support for SD_PREFER_SIBLING
> 
> Change from v1
>    -. clean up the patch
> 
> Byungchul Park (2):
>   sched/deadline: Add support for SD_PREFER_SIBLING on find_later_rq()
>   sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()
> 
>  kernel/sched/deadline.c | 82 ++++++++++++++++++++++++++++++++++++++++++++-----
>  kernel/sched/rt.c       | 80 +++++++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 152 insertions(+), 10 deletions(-)
> 
> -- 
> 1.9.1