linux-kernel - Re: [PATCH] drm/omap: displays: panel-dpi: add backlight dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f893de86-a16a-964f-a998-e574f75bf3d4@ti.com>
Date:   Thu, 12 Oct 2017 11:05:45 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Arnd Bergmann <arnd@...db.de>, David Airlie <airlied@...ux.ie>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/omap: displays: panel-dpi: add backlight dependency


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 05/10/17 15:06, Arnd Bergmann wrote:
> The new backlight code causes a link failure when backlight
> support itself is disabled:
> 
> drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of':
> panel-dpi.c:(.text+0x35c): undefined reference to `of_find_backlight_by_node'
> 
> This adds a Kconfig dependency like we have for the other OMAP
> display targets.
> 
> Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling backlight devices")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/gpu/drm/omapdrm/displays/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig b/drivers/gpu/drm/omapdrm/displays/Kconfig
> index c226da145fb3..a349cb61961e 100644
> --- a/drivers/gpu/drm/omapdrm/displays/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig
> @@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV
>  
>  config DRM_OMAP_PANEL_DPI
>  	tristate "Generic DPI panel"
> +	depends on BACKLIGHT_CLASS_DEVICE
>  	help
>  	  Driver for generic DPI panels.

Thanks, I've queued this for 4.14 fixes.

 Tomi