linux-kernel - Re: [PATCH] tracing/xen: Hide events that are not used when X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171011210542.6ac512e7@gandalf.local.home>
Date:   Wed, 11 Oct 2017 21:05:42 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Jeremy Linton <jeremy.linton@....com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH] tracing/xen: Hide events that are not used when X86_PAE
 is not defined

On Wed, 11 Oct 2017 19:39:20 -0500
Jeremy Linton <jeremy.linton@....com> wrote:

> On 10/10/2017 06:12 PM, Steven Rostedt wrote:
> > From: Steven Rostedt (VMware) <rostedt@...dmis.org>
> > 
> > TRACE_EVENTS() take up memory. If they are defined but not used, then
> > they simply waste space. If their use case is behind a define, then the
> > trace events should be as well.
> > 
> > The trace events xen_mmu_set_pte_atomic, xen_mmu_pte_clear, and
> > xen_mmu_pmd_clear are not used when CONFIG_X86_PAE is not defined.  
> 
> The only place i see them being used is mmu_pv.c, where they are wrapped 
> in the stated #define.
> 
> Looks good.
> 
> Reviewed-by: Jeremy Linton <jeremy.linton@....com>
> 

Thanks Jeremy,

-- Steve