linux-kernel - Re: [PATCH 2/8] mm, truncate: Do not check mapping for every page being truncated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171012124107.fk63gk656jhzgodh@techsingularity.net>
Date:   Thu, 12 Oct 2017 13:41:07 +0100
From:   Mel Gorman <mgorman@...hsingularity.net>
To:     Jan Kara <jack@...e.cz>
Cc:     Linux-MM <linux-mm@...ck.org>,
        Linux-FSDevel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Dave Chinner <david@...morbit.com>
Subject: Re: [PATCH 2/8] mm, truncate: Do not check mapping for every page
 being truncated

On Thu, Oct 12, 2017 at 02:15:27PM +0200, Jan Kara wrote:
> > diff --git a/mm/workingset.c b/mm/workingset.c
> > index 7119cd745ace..a80d52387734 100644
> > --- a/mm/workingset.c
> > +++ b/mm/workingset.c
> > @@ -341,12 +341,6 @@ static struct list_lru shadow_nodes;
> >  
> >  void workingset_update_node(struct radix_tree_node *node, void *private)
> >  {
> > -	struct address_space *mapping = private;
> > -
> > -	/* Only regular page cache has shadow entries */
> > -	if (dax_mapping(mapping) || shmem_mapping(mapping))
> > -		return;
> > -
> 
> Hum, we don't need to pass 'mapping' from call sites then? Either pass NULL
> or just remove the argument completely since nobody needs it anymore...
> Otherwise the patch looks good.
> 

You're right. Initially, I was preserving the signature as it's defined
by radix_tree_update_node_t but the only user is workingset_update_node
so it can be changed.

-- 
Mel Gorman
SUSE Labs