linux-kernel - Re: [PATCH v3 0/5] Switch arm64 over to qrwlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53399b22-8062-aa06-8569-e3fb0ae70ff0@codeaurora.org>
Date:   Thu, 12 Oct 2017 09:16:33 -0400
From:   Adam Wallis <awallis@...eaurora.org>
To:     Will Deacon <will.deacon@....com>, linux-kernel@...r.kernel.org
Cc:     peterz@...radead.org, boqun.feng@...il.com, Jeremy.Linton@....com,
        mingo@...hat.com, longman@...hat.com, paulmck@...ux.vnet.ibm.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 0/5] Switch arm64 over to qrwlock

On 10/12/2017 8:20 AM, Will Deacon wrote:
> Hello,
> 
> This is version three of the patches previously posted here:
> 
> v1: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534666.html
> v2: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/534981.html
> 
> Changes since v2 include:
> 
>   * Drop unused cnt argument
>   * Fix typo in UNLOCK Kconfig inlining options
>   * Added Tested-by tags
> 
> Thanks to all of those who provided review and testing feedback!
> 
> Will
> 
> --->8
> 
> Will Deacon (5):
>   kernel/locking: Use struct qrwlock instead of struct __qrwlock
>   locking/atomic: Add atomic_cond_read_acquire
>   kernel/locking: Use atomic_cond_read_acquire when spinning in qrwlock
>   arm64: locking: Move rwlock implementation over to qrwlocks
>   kernel/locking: Prevent slowpath writers getting held up by fastpath
> 
>  arch/arm64/Kconfig                      |  17 ++++
>  arch/arm64/include/asm/Kbuild           |   1 +
>  arch/arm64/include/asm/spinlock.h       | 164 +-------------------------------
>  arch/arm64/include/asm/spinlock_types.h |   6 +-
>  include/asm-generic/atomic-long.h       |   3 +
>  include/asm-generic/qrwlock.h           |  37 ++-----
>  include/asm-generic/qrwlock_types.h     |  15 ++-
>  include/linux/atomic.h                  |   4 +
>  kernel/locking/qrwlock.c                |  86 +++--------------
>  9 files changed, 61 insertions(+), 272 deletions(-)
> 

Will, I see the same performance improvements that I was getting in v2 of the
patch. I will continue to run these patches on multiple systems over the next
few weeks, months for stability/functionality testing as well.

Tested-by: Adam Wallis <awallis@...eaurora.org>

-- 
Adam Wallis
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.