linux-kernel - Re: powerpc: Drop lockdep_assert_cpus_held call from arch_update_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3yCBLz4n8zz9t2Z@ozlabs.org>
Date:   Thu, 12 Oct 2017 11:20:11 +1100 (AEDT)
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org
Cc:     Daniel Black <daniel.black@....ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org,
        Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com>
Subject: Re: powerpc: Drop lockdep_assert_cpus_held call from arch_update_cpu_topology

On Thu, 2017-10-05 at 00:04:30 UTC, Thiago Jung Bauermann wrote:
> It turns out that not all paths calling arch_update_cpu_topology hold
> cpu_hotplug_lock, but that's ok because those paths aren't supposed to race
> with any concurrent hotplug events.
> 
> Callers of arch_update_cpu_topology are expected to know what they are
> doing when they call the function without holding the lock, so remove the
> lockdep warning.
...
> 
> Signed-off-by: Thiago Jung Bauermann <bauerman@...ux.vnet.ibm.com>
> Fixes: 3e401f7a2e51 ("powerpc: Only obtain cpu_hotplug_lock if called by rtasd")
> Link: https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-September/163244.html
> Link: https://github.com/linuxppc/linux/issues/106

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/6b2c08f989250c54f31b53dba9ace8

cheers