linux-kernel - [tip:x86/urgent] x86/apic: Silence "FW_BUG TSC_DEADLINE disabled due to Errata" on hypervisors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-cc6afe2240298049585e86b1ade85efc8a7f225d@git.kernel.org>
Date:   Thu, 12 Oct 2017 08:12:53 -0700
From:   tip-bot for Paolo Bonzini <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hdegoede@...hat.com, linux-kernel@...r.kernel.org,
        pbonzini@...hat.com, mingo@...nel.org, tglx@...utronix.de,
        peterz@...radead.org, hpa@...or.com
Subject: [tip:x86/urgent] x86/apic: Silence "FW_BUG TSC_DEADLINE disabled
 due to Errata" on hypervisors

Commit-ID:  cc6afe2240298049585e86b1ade85efc8a7f225d
Gitweb:     https://git.kernel.org/tip/cc6afe2240298049585e86b1ade85efc8a7f225d
Author:     Paolo Bonzini <pbonzini@...hat.com>
AuthorDate: Tue, 10 Oct 2017 12:12:57 +0200
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 12 Oct 2017 17:10:10 +0200

x86/apic: Silence "FW_BUG TSC_DEADLINE disabled due to Errata" on hypervisors

Commit 594a30fb1242 ("x86/apic: Silence "FW_BUG TSC_DEADLINE disabled
due to Errata" on CPUs without the feature", 2017-08-30) was also about
silencing the warning on VirtualBox; however, KVM does expose the TSC
deadline timer, and it's virtualized so that it is immune from CPU errata.

Therefore, booting 4.13 with "-cpu Haswell" shows this in the logs:

     [    0.000000] [Firmware Bug]: TSC_DEADLINE disabled due to Errata;
                    please update microcode to version: 0xb2 (or later)

Even if you had a hypervisor that does _not_ virtualize the TSC deadline
and rather exposes the hardware one, it should be the hypervisors task
to update microcode and possibly hide the flag from CPUID.  So just
hide the message when running on _any_ hypervisor, not just those that
do not support the TSC deadline timer.

The older check still makes sense, so keep it.

Fixes: bd9240a18e ("x86/apic: Add TSC_DEADLINE quirk due to errata")
Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Hans de Goede <hdegoede@...hat.com>
Cc: kvm@...r.kernel.org
Cc: stable@...r.kernel.org
Link: https://lkml.kernel.org/r/1507630377-54471-1-git-send-email-pbonzini@redhat.com

---
 arch/x86/kernel/apic/apic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index d705c76..50109ea 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -600,7 +600,8 @@ static void apic_check_deadline_errata(void)
 	const struct x86_cpu_id *m;
 	u32 rev;
 
-	if (!boot_cpu_has(X86_FEATURE_TSC_DEADLINE_TIMER))
+	if (!boot_cpu_has(X86_FEATURE_TSC_DEADLINE_TIMER) ||
+	    boot_cpu_has(X86_FEATURE_HYPERVISOR))
 		return;
 
 	m = x86_match_cpu(deadline_match);