linux-kernel - Re: [PATCH] drivers/video/fbdev/atyfb: make const arrays static, reduces object code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <10191317.Qqof1SveHP@amdc3058>
Date:   Thu, 12 Oct 2017 17:26:56 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Colin King <colin.king@...onical.com>
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/video/fbdev/atyfb: make const arrays static,
 reduces object code size

On Wednesday, September 13, 2017 04:03:09 PM Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the const arrays ragepro_tbl and ragexl_tbl on the stack,
> instead make them static.  Makes the object code smaller by over 380 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   41089	  10592	    768	  52449	   cce1 atyfb_base.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   40544	  10752	    768	  52064	   cb60	atyfb_base.o
> 
> (gcc version 7.2.0, x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch queued for 4.15 (with patch description fixed to
"video: fbdev: aty: ..." for consistency with other patches),
thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics