linux-kernel - Re: [PATCH] elf_fdpic: fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a29hCmhdGWdh--PR9wx-u79i37HmhtQeBK+e0NvkDU8fw@mail.gmail.com>
Date:   Thu, 12 Oct 2017 17:27:29 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Nicolas Pitre <nicolas.pitre@...aro.org>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Ingo Molnar <mingo@...nel.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] elf_fdpic: fix unused variable warning

On Thu, Oct 12, 2017 at 5:21 PM, Nicolas Pitre <nicolas.pitre@...aro.org> wrote:
> On Thu, 12 Oct 2017, Arnd Bergmann wrote:
>
>> The elf_fdpic code shows a harmless warning when built with MMU
>> enabled, I ran into this now that the configuration is possible
>> on ARM randconfig builds:
>>
>> fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments':
>> fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable]
>
> In fact the warning appears when built *without* MMU.

Ah, of course.

>> Who should pick this up? I guess it could go through either the
>> ARM tree that introduced the warning for ARM and contains a number
>> of fdpic patches, or it could go through the VFS tree.
>
> Given the above I'd say the VFS tree.

Ok, I'll create a new version, thanks for taking a look.

      Arnd