linux-kernel - Re: [PATCH] elf_fdpic: fix unused variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171012153456.GE21978@ZenIV.linux.org.uk>
Date:   Thu, 12 Oct 2017 16:34:57 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Nicolas Pitre <nico@...aro.org>, Ingo Molnar <mingo@...nel.org>,
        Nicolas Pitre <nicolas.pitre@...aro.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Mickael GUENE <mickael.guene@...com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] elf_fdpic: fix unused variable warning

On Thu, Oct 12, 2017 at 05:31:46PM +0200, Arnd Bergmann wrote:
> The elf_fdpic code shows a harmless warning when built with MMU disabled,
> I ran into this now that fdpic is available on ARM randconfig builds
> since commit 50b2b2e691cd ("ARM: add ELF_FDPIC support").
> 
> fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments':
> fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable]
> 
> This adds another #ifdef around the variable declaration to shut up
> the warning.
> 
> Fixes: e6c1baa9b562 ("convert the rest of binfmt_elf_fdpic to dump_emit()")
> Acked-by: Nicolas Pitre <nico@...aro.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied...