linux-kernel - Re: [PATCH v2 5/5] btrfs: ensure that metadata and flush are issued from the root cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171012153854.GR3301751@devbig577.frc2.facebook.com>
Date:   Thu, 12 Oct 2017 08:38:54 -0700
From:   Tejun Heo <tj@...nel.org>
To:     dsterba@...e.cz, jack@...e.cz, axboe@...nel.dk, clm@...com,
        jbacik@...com, kernel-team@...com, linux-kernel@...r.kernel.org,
        linux-btrfs@...r.kernel.org
Subject: Re: [PATCH v2 5/5] btrfs: ensure that metadata and flush are issued
 from the root cgroup

On Wed, Oct 11, 2017 at 07:07:23PM +0200, David Sterba wrote:
> The comment is useful, but the condition will be always true, so I don't
> see the point.
> 
> 	/*
> 	 * The btree_inode will be always in the root cgroup. The cgroup
> 	 * writeback can be enabled on regular inodes selectively.
> 	 */
> 	new_fl |= S_CGROUPWB;
> 
> is IMHO enough, based on my reading of patch 2/5 changelog.

Will update accordingly.

Thanks.

-- 
tejun