linux-kernel - Re: [PATCH 2/2] perf, tools: Don't force MetricExprs to lower case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171012155942.GA15716@krava>
Date:   Thu, 12 Oct 2017 17:59:42 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     "Wangnan (F)" <wangnan0@...wei.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Andi Kleen <andi@...stfloor.org>, Jiri Olsa <jolsa@...nel.org>,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
        He Kuang <hekuang@...wei.com>, Alexei Starovoitov <ast@...com>
Subject: Re: [PATCH 2/2] perf, tools: Don't force MetricExprs to lower case

On Thu, Oct 12, 2017 at 11:31:51PM +0800, Wangnan (F) wrote:

SNIP

> > > > Ok. If it works it's fine for me.
> > well it works, but it means that bpf file cannot contains any directory
> > part.. which im not sure is ok with bpf folks ;-) anyone?
> 
> Sorry I didn't see this thread these days.
> 
> Do you think adding a special escape character to suppress BPF
> name parsing in a event is a good idea? for example:
> 
> % perf stat -e cpu/uops_executed.core,cmask=1/ true
> bpf: builtin compilation failed: -95, try external compiler
> ERROR: problems with path cpu/uops_executed.c: No such file or directory
> event syntax error: 'cpu/uops_executed.core,cmask=1/'
>                      \___ Failed to load cpu/uops_executed.c from source:
> Error when compiling BPF scriptlet. Add a leading '@' to avoid BPF syntax
> 
> % perf stat -e @cpu/uops_executed.core,cmask=1/ true
> ...
> 

if we go this way, I'd rather mark the bpf syntax
instead of changing the generic event format,
like Andi suggested in some earlier email

but maybe we can workaround this with patch
I sent in my last email

thanks,
jirka