linux-kernel - Re: [PATCH] video: fbdev: radeon: make const array post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <3245965.OqUEzHD6FT@amdc3058>
Date:   Thu, 12 Oct 2017 18:17:07 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linux-fbdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] video: fbdev: radeon: make const array post_divs
 static, reduces object code size


[ added dri-devel ML to cc: ]

On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the read-only const array post_divs on the stack,
> nstead make it static. Makes the object code smaller by 90 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   40231	   8584	    896	  49711	   c22f	radeon_base.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   39914	   8744	    960	  49618	   c1d2	radeon_base.o
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Are these results obtained using the same compiler as the other patches
(gcc version 7.2.0, x86_64)?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics