linux-kernel - Re: [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171012110249.7d41ff02@lwn.net>
Date:   Thu, 12 Oct 2017 11:02:49 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     shuah@...nel.org, linux-kselftest@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] doc: dev-tools: kselftest.rst: update to include make
 O=dir support

On Mon,  2 Oct 2017 17:44:17 -0600
Shuah Khan <shuahkh@....samsung.com> wrote:

> Update to include details on make O=dir support and other changes improve
> test results output.

So the three patches you sent me appear to be a part of a larger series
that I didn't get.  I'll assume you want me to apply these three...

> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>  Documentation/dev-tools/kselftest.rst | 34 ++++++++++++++++++++++++++++++++--
>  1 file changed, 32 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index ebd03d11d2c2..0aa6dde835d1 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -31,6 +31,17 @@ To build and run the tests with a single command, use::
>  
>  Note that some tests will require root privileges.
>  
> +Build and run from user specific object directory (make O=dir):
> +
> +  $ make O=/tmp/kselftest kselftest
> +
> +Build and run KBUILD_OUTPUT directory (make KBUILD_OUTPUT=):
> +
> +  $ make KBUILD_OUTPUT=/tmp/kselftest kselftest
> +

These lines should really end with a double colon like this:

	Build and run from user specific object directory (make O=dir)::

That indicates that what follows is to be formatted as code, and makes it
match the rest of the document.  I took the liberty of fixing these up on
the way in.

All three applied, thanks.

jon