linux-kernel - Re: [PATCH 11/12] nvmem: meson-efuse: indicate that this driver is only for Meson GX SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCBnSiePnQRYTy=WXi5er1Z3HWH8GKngv3oRoaGb5r5ySQ@mail.gmail.com>
Date:   Thu, 12 Oct 2017 22:51:46 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     srinivas.kandagatla@...aro.org
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/12] nvmem: meson-efuse: indicate that this driver is
 only for Meson GX SoCs

On Mon, Oct 9, 2017 at 3:26 PM,  <srinivas.kandagatla@...aro.org> wrote:
> From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
>
> The current Amlogic Meson eFuse driver only supports the 64-bit SoCs
> (GXBB and newer). Older SoCs cannot be supported by the same driver
> because they do not use the meson secure monitor firmware to access the
> hardware.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
I also got Rob's ACK for this patch, see [0]

> ---
>  Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt | 2 +-
>  drivers/nvmem/Kconfig                                     | 4 ++--
>  drivers/nvmem/meson-efuse.c                               | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> index fafd85bd67a6..e3298e18de26 100644
> --- a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> @@ -1,4 +1,4 @@
> -= Amlogic eFuse device tree bindings =
> += Amlogic Meson GX eFuse device tree bindings =
>
>  Required properties:
>  - compatible: should be "amlogic,meson-gxbb-efuse"
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 2755df8f6e9b..e364c925e10c 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -146,11 +146,11 @@ config NVMEM_VF610_OCOTP
>           be called nvmem-vf610-ocotp.
>
>  config MESON_EFUSE
> -       tristate "Amlogic eFuse Support"
> +       tristate "Amlogic Meson GX eFuse Support"
>         depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM
>         help
>           This is a driver to retrieve specific values from the eFuse found on
> -         the Amlogic Meson SoCs.
> +         the Amlogic Meson GX SoCs.
>
>           This driver can also be built as a module. If so, the module
>           will be called nvmem_meson_efuse.
> diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c
> index dbedfcea4e05..a43c68f90937 100644
> --- a/drivers/nvmem/meson-efuse.c
> +++ b/drivers/nvmem/meson-efuse.c
> @@ -1,5 +1,5 @@
>  /*
> - * Amlogic eFuse Driver
> + * Amlogic Meson GX eFuse Driver
>   *
>   * Copyright (c) 2016 Endless Computers, Inc.
>   * Author: Carlo Caione <carlo@...lessm.com>
> @@ -88,5 +88,5 @@ static struct platform_driver meson_efuse_driver = {
>  module_platform_driver(meson_efuse_driver);
>
>  MODULE_AUTHOR("Carlo Caione <carlo@...lessm.com>");
> -MODULE_DESCRIPTION("Amlogic Meson NVMEM driver");
> +MODULE_DESCRIPTION("Amlogic Meson GX NVMEM driver");
>  MODULE_LICENSE("GPL v2");
> --
> 2.11.0
>


[0] http://lists.infradead.org/pipermail/linux-amlogic/2017-October/004944.html