linux-kernel - Re: [PATCH] scripts: fix faddr2line to work on last symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wp40m4e3.fsf@notabene.neil.brown.name>
Date:   Fri, 13 Oct 2017 08:40:20 +1100
From:   NeilBrown <neilb@...e.com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts: fix faddr2line to work on last symbol

On Thu, Oct 12 2017, Josh Poimboeuf wrote:

> On Thu, Oct 12, 2017 at 02:22:04PM +1100, NeilBrown wrote:
>> 
>> If faddr2line is given a function name which is the
>> last one listed by "nm -n", it will fail because it
>> never finds the next symbol.
>> 
>> So teach the awk script to catch that possibility,
>> and use 'size' to provide the end point of the last
>> function.
>> 
>> Signed-off-by: NeilBrown <neilb@...e.com>
>
> Thanks.  I'm assuming you saw this issue with a .o file, and not with
> vmlinux?  Because on my vmlinux, the last symbol isn't a text symbol.

Yes, I was using a .o

Thanks for looking further into this - there certainly are subtleties
that I missed.

Thanks,
NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)