linux-kernel - Re: [PATCH] btrfs: Clean up unused variables in free-space-tree.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171012214327.GA16154@vader.DHCP.thefacebook.com>
Date:   Thu, 12 Oct 2017 14:43:27 -0700
From:   Omar Sandoval <osandov@...ndov.com>
To:     Christos Gkekas <chris.gekas@...il.com>
Cc:     Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: Clean up unused variables in free-space-tree.c

On Thu, Oct 12, 2017 at 10:40:42PM +0100, Christos Gkekas wrote:
> Remove variables 'start' and 'end', which are set but never used.

Oops.

Reviewed-by: Omar Sandoval <osandov@...com>

> Signed-off-by: Christos Gkekas <chris.gekas@...il.com>
> ---
>  fs/btrfs/free-space-tree.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c
> index 684f122..fe5e032 100644
> --- a/fs/btrfs/free-space-tree.c
> +++ b/fs/btrfs/free-space-tree.c
> @@ -1286,12 +1286,8 @@ static int __add_block_group_free_space(struct btrfs_trans_handle *trans,
>  					struct btrfs_block_group_cache *block_group,
>  					struct btrfs_path *path)
>  {
> -	u64 start, end;
>  	int ret;
>  
> -	start = block_group->key.objectid;
> -	end = block_group->key.objectid + block_group->key.offset;
> -
>  	block_group->needs_free_space = 0;
>  
>  	ret = add_new_free_space_info(trans, fs_info, block_group, path);
> -- 
> 2.7.4
>