linux-kernel - Re: [Outreachy kernel] [PATCH] Staging: speakup: Replace symbolic permissions with octal permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1710132343330.3147@hadrien>
Date:   Fri, 13 Oct 2017 23:44:01 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Shreeya Patel <shreeya.patel23498@...il.com>
cc:     gregkh@...uxfoundation.org, w.d.hubbs@...il.com,
        chris@...-brannons.com, kirk@...sers.ca,
        samuel.thibault@...-lyon.org, speakup@...ux-speakup.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: speakup: Replace symbolic
 permissions with octal permissions



On Sat, 14 Oct 2017, Shreeya Patel wrote:

> Resolve following checkpatch issue:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
> Consider using octal permissions '0444'.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@...il.com>
> ---
>  drivers/staging/speakup/speakup_bns.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/speakup_bns.c b/drivers/staging/speakup/speakup_bns.c
> index 60bcf0d..402b0fb 100644
> --- a/drivers/staging/speakup/speakup_bns.c
> +++ b/drivers/staging/speakup/speakup_bns.c
> @@ -120,7 +120,7 @@ static struct spk_synth synth_bns = {
>  };
>
>  module_param_named(ser, synth_bns.ser, int, 0444);
> -module_param_named(dev, synth_bns.dev_name, charp, S_IRUGO);
> +module_param_named(dev, synth_bns.dev_name, charp, 0444);

This change is already made.  You need to update your staging tree.

julia

>  module_param_named(start, synth_bns.startup, short, 0444);
>
>  MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1507930425-5471-1-git-send-email-shreeya.patel23498%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>