linux-kernel - Re: [PATCH] s390/pkey: fix kzalloc-simple.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <dc6cb53f-4f1d-988f-ec99-0344c5fc94f6@linux.vnet.ibm.com>
Date:   Fri, 13 Oct 2017 08:36:59 +0200
From:   Harald Freudenberger <freude@...ux.vnet.ibm.com>
To:     Vasyl Gomonovych <gomonovych@...il.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     freude@...ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com
Subject: Re: [PATCH] s390/pkey: fix kzalloc-simple.cocci warnings

On 10/11/2017 09:52 PM, Vasyl Gomonovych wrote:
> drivers/s390/crypto/pkey_api.c:128:11-18: WARNING: kzalloc should be used for cprbmem, instead of kmalloc/memset
>
> Use kzalloc rather than kmalloc followed by memset with 0
>
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
> ---
>  drivers/s390/crypto/pkey_api.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/s390/crypto/pkey_api.c b/drivers/s390/crypto/pkey_api.c
> index f61fa47..8dda5bb 100644
> --- a/drivers/s390/crypto/pkey_api.c
> +++ b/drivers/s390/crypto/pkey_api.c
> @@ -125,10 +125,9 @@ static int alloc_and_prep_cprbmem(size_t paramblen,
>  	 * allocate consecutive memory for request CPRB, request param
>  	 * block, reply CPRB and reply param block
>  	 */
> -	cprbmem = kmalloc(2 * cprbplusparamblen, GFP_KERNEL);
> +	cprbmem = kzalloc(2 * cprbplusparamblen, GFP_KERNEL);
>  	if (!cprbmem)
>  		return -ENOMEM;
> -	memset(cprbmem, 0, 2 * cprbplusparamblen);
>
>  	preqcblk = (struct CPRBX *) cprbmem;
>  	prepcblk = (struct CPRBX *) (cprbmem + cprbplusparamblen);
applied, will be available with the next merge window.
Thanks