linux-kernel - Re: [PATCH] kmemcheck: correctly remove kmemcheck call from dma_map_sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171013071121.4v73j7gn472ezv23@dhcp22.suse.cz>
Date:   Fri, 13 Oct 2017 09:11:21 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>
Cc:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kmemcheck: correctly remove kmemcheck call from
 dma_map_sg_attrs

On Thu 12-10-17 19:22:05, Sasha Levin wrote:
> We have missed removing some code as part of removing the kmemcheck
> hooks.
> 
> Unfourtenatly this got missed during my review, and the code was
> still building.
> 
> Reported-by: Michal Hocko <mhocko@...nel.org>
> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>

Yes this would be the proper fix for the specific issue I have noticed.
There might be others I haven't even checked. Really the only way to
make this chage is to post a reproducible steps to regenerate your diff
and review that the used scripts are correct. Follow up fixes are not a
way to go

> ---
>  include/linux/dma-mapping.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 83f3ab31efc4..2911389bc147 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -260,10 +260,8 @@ static inline int dma_map_sg_attrs(struct device *dev, struct scatterlist *sg,
>  				   unsigned long attrs)
>  {
>  	const struct dma_map_ops *ops = get_dma_ops(dev);
> -	int i, ents;
> -	struct scatterlist *s;
> +	int ents;
>  
> -	for_each_sg(sg, s, nents, i)
>  	BUG_ON(!valid_dma_direction(dir));
>  	ents = ops->map_sg(dev, sg, nents, dir, attrs);
>  	BUG_ON(ents < 0);
> -- 
> 2.11.0

-- 
Michal Hocko
SUSE Labs