linux-kernel - Re: [PATCH 1/2] dt-bindings: mfd: Add Spreadtrum SC27xx PMIC documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMz4kuKpnH8_LwjN_qr4sbyWh6_03U_a9FH60B_-Gy77CQZiOQ@mail.gmail.com>
Date:   Fri, 13 Oct 2017 17:28:59 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Baolin Wang <baolin.wang@...eadtrum.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: mfd: Add Spreadtrum SC27xx PMIC documentation

Hi Lee,

On 13 October 2017 at 17:07, Lee Jones <lee.jones@...aro.org> wrote:
> On Wed, 11 Oct 2017, Baolin Wang wrote:
>
>> This patch adds the binding documentation for Spreadtrum SC27xx series
>> PMIC device.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@...eadtrum.com>
>> ---
>>  .../devicetree/bindings/mfd/sprd,sc27xx-pmic.txt   |   23 ++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt b/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt
>> new file mode 100644
>> index 0000000..333c818
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/sprd,sc27xx-pmic.txt
>> @@ -0,0 +1,23 @@
>> +Spreadtrum SC27xx Power Management Integrated Circuit (PMIC)
>
> More info please.
>
> What does the ship do and what other devices are available.

OK. I will add more information in next version.

>
>> +Required properties:
>> +- compatible: Should be "sprd,sc2731".
>> +- reg: SPI chip select.
>
> Really?  Not an address?

Yes, it should be device address.

>
> What is the range?
>
>> +- spi-max-frequency: Typically set to 26000000.
>> +- interrupts: The interrupt line the device is connected to.
>> +- interrupt-controller: Marks the device node as an interrupt controller.
>> +- #interrupt-cells: The number of cells to describe an PMIC IRQ, should be 2.
>
> What if it's not 2?  Will it still work?

Must be 2, if not it can not work well. Will update in next version.

>
>> +- #address-cells: Child device offset number of cells, should be 1.
>
> Same.

OK.

>
>> +- #size-cells: Child device size number of cells, should be 0.
>
> Same.

OK.

>
>> +
>> +Example:
>> +pmic: pmic@0 {
>
> What other nodes are you referencing this one from?

This node should be under our ADI/SPI master device node, as one SPI
device. I will add the SPI master node in next version. Very
appreciated for your comments.

-- 
Baolin.wang
Best Regards