linux-kernel - Re: [PATCH] staging: rtsx: Add support for RTS5260

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171013092659.GA28241@kroah.com>
Date:   Fri, 13 Oct 2017 11:26:59 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     rui_feng@...lsil.com.cn
Cc:     lee.jones@...aro.org, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org, ricky_wu@...ltek.com
Subject: Re: [PATCH] staging: rtsx: Add support for RTS5260

On Fri, Oct 13, 2017 at 04:50:35PM +0800, rui_feng@...lsil.com.cn wrote:
> From: rui_feng <rui_feng@...lsil.com.cn>
> 
> Add support for new chip rts5260.
> In order to support rts5260，the definitions of some internal
> registers and workflow have to be modified and are different from its
> predecessors and OCP function is added for RTS5260.
> So we need this patch to ensure RTS5260 can work.
> 
> Signed-off-by: Rui Feng <rui_feng@...lsil.com.cn>

Your from and signed-off-by name does not match :(

> ---
>  drivers/mfd/Makefile              |   4 +
>  drivers/mfd/rtsx_pcr.c            | 127 ++++++-
>  drivers/mfd/rtsx_pcr.h            |  12 +
>  drivers/staging/Kconfig           |   2 +
>  drivers/staging/rts5260/Kconfig   |   6 +
>  drivers/staging/rts5260/rts5260.c | 748 ++++++++++++++++++++++++++++++++++++++
>  drivers/staging/rts5260/rts5260.h |  45 +++
>  include/linux/mfd/rtsx_pci.h      | 234 +++++++++++-

I do not see a reason why this is a staging driver.  Where is the TODO
file listing what needs to be done to get it out of staging?  Why can it
not just go into the "real" part of the kernel?

thanks,

greg k-h