linux-kernel - Re: ath10k: fix core PCI suspend when WoWLAN is supported but disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Oct 2017 13:37:37 +0200
From:   Kalle Valo <kvalo@....qualcomm.com>
To:     Brian Norris <briannorris@...omium.org>
CC:     <ath10k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
        "Grant Grundler" <grundler@...omium.org>,
        <linux-kernel@...r.kernel.org>,
        "Brian Norris" <briannorris@...omium.org>,
        Ryan Hsu <ryanhsu@....qualcomm.com>,
        Michal Kazior <michal.kazior@...to.com>
Subject: Re: ath10k: fix core PCI suspend when WoWLAN is supported but disabled

Brian Norris <briannorris@...omium.org> wrote:

> For devices where the FW supports WoWLAN but user-space has not
> configured it, we don't do any PCI-specific suspend/resume operations,
> because mac80211 doesn't call drv_suspend() when !wowlan. This has
> particularly bad effects for some platforms, because we don't stop the
> power-save timer, and if this timer goes off after the PCI controller
> has suspended the link, Bad Things will happen.
> 
> Commit 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops")
> got some of this right, in that it understood there was a problem on
> non-WoWLAN firmware. But it forgot the $subject case.
> 
> Fix this by moving all the PCI driver suspend/resume logic exclusively
> into the driver PM hooks. This shouldn't affect WoWLAN support much
> (this just gets executed later on).
> 
> I would just as well kill the entirety of ath10k_hif_suspend(), as it's
> not even implemented on the USB or SDIO drivers. I expect that we don't
> need the callback, except to return "supported" (i.e., 0) or "not
> supported" (i.e., -EOPNOTSUPP).
> 
> Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops")
> Fixes: 77258d409ce4 ("ath10k: enable pci soc powersaving")
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> Cc: Ryan Hsu <ryanhsu@....qualcomm.com>
> Cc: Kalle Valo <kvalo@....qualcomm.com>
> Cc: Michal Kazior <michal.kazior@...to.com>
> Signed-off-by: Kalle Valo <kvalo@....qualcomm.com>

Patch applied to ath-next branch of ath.git, thanks.

96378bd2c6cd ath10k: fix core PCI suspend when WoWLAN is supported but disabled

-- 
https://patchwork.kernel.org/patch/9960481/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches