linux-kernel - Re: [PATCH] thunderbolt: Fix some right shifting to zero bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171013114210.GE2761@lahna.fi.intel.com>
Date:   Fri, 13 Oct 2017 14:42:10 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: Fix some right shifting to zero bugs

On Fri, Oct 13, 2017 at 02:29:59PM +0300, Dan Carpenter wrote:
> The problematic code looks like this:
> 
> 	res_seq = res_hdr->xd_hdr.length_sn & TB_XDOMAIN_SN_MASK;
> 	res_seq >>= TB_XDOMAIN_SN_SHIFT;
> 
> TB_XDOMAIN_SN_SHIFT is 27, and right shifting a u8 27 bits is always
> going to result in zero.  The fix is to declare these variables as u32.
> 
> Fixes: d1ff70241a27 ("thunderbolt: Add support for XDomain discovery protocol")

I think this requires two patches as the drivers/net/thunderbolt.c is
added by another commit.

Also please CC netdev@...r.kernel.org and David Miller as the patches
are in his net-next tree.

The fixes themselves look good, though.