linux-kernel - Re: [PATCH] tracing: hide unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0=JrfLz0NFA2LtfX4v4Cvwv_NSQfKvq6eKG88WHU5pmQ@mail.gmail.com>
Date:   Fri, 13 Oct 2017 15:02:34 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Joel Fernandes <joelaf@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: hide unused functions

On Fri, Oct 13, 2017 at 2:01 PM, Arnd Bergmann <arnd@...db.de> wrote:
> After trace_selftest_startup_sched_switch is removed, trace_test_buffer()
> is now only used inside of CONFIG_FUNCTION_TRACER, leading to this
> warning:
>
> kernel/trace/trace_selftest.c:62:12: error: 'trace_test_buffer' defined but not used [-Werror=unused-function]
>
> The same is true for a few other functions called by trace_test_buffer(),
> so let's extend the #ifdef to cover all of them together.
>
> Fixes: d8c4deee6dc6 ("tracing: Remove obsolete sched_switch tracer selftest")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Nevermind, I ran into another problem with this applied: trace_test_buffer()
is used elsewhere after all, just not for all possible combinations.

Maybe marking it as __maybe_unused would be more appropriate?

      Arnd