linux-kernel - Re: [PATCH v2 9/9] dt-bindings: usb: mtk-xhci: remove dummy clocks and add optional ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Oct 2017 15:56:12 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-usb@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 9/9] dt-bindings: usb: mtk-xhci: remove dummy clocks
 and add optional ones



On 10/13/2017 10:26 AM, Chunfeng Yun wrote:
> Remove dummy clocks for usb wakeup and add optional ones for
> MCU_BUS_CK and DMA_BUS_CK.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> Acked-by: Rob Herring <robh@...nel.org>
> ---

Reviewed-by: <matthias.bgg@...il.com>

>   .../devicetree/bindings/usb/mediatek,mtk-xhci.txt  |   18 ++++++++----------
>   1 file changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> index 2d9b459..3059596 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> @@ -26,10 +26,11 @@ Required properties:
>    - clocks : a list of phandle + clock-specifier pairs, one for each
>   	entry in clock-names
>    - clock-names : must contain
> -	"sys_ck": for clock of xHCI MAC
> -	"ref_ck": for reference clock of xHCI MAC
> -	"wakeup_deb_p0": for USB wakeup debounce clock of port0
> -	"wakeup_deb_p1": for USB wakeup debounce clock of port1
> +	"sys_ck": controller clock used by normal mode,
> +	the following ones are optional:
> +	"ref_ck": reference clock used by low power mode etc,
> +	"mcu_ck": mcu_bus clock for register access,
> +	"dma_ck": dma_bus clock for data transfer by DMA
>   
>    - phys : a list of phandle + phy specifier pairs
>   
> @@ -57,9 +58,7 @@ usb30: usb@...70000 {
>   	clocks = <&topckgen CLK_TOP_USB30_SEL>, <&clk26m>,
>   		 <&pericfg CLK_PERI_USB0>,
>   		 <&pericfg CLK_PERI_USB1>;
> -	clock-names = "sys_ck", "ref_ck",
> -		      "wakeup_deb_p0",
> -		      "wakeup_deb_p1";
> +	clock-names = "sys_ck", "ref_ck";
>   	phys = <&phy_port0 PHY_TYPE_USB3>,
>   	       <&phy_port1 PHY_TYPE_USB2>;
>   	vusb33-supply = <&mt6397_vusb_reg>;
> @@ -91,9 +90,8 @@ Required properties:
>   
>    - clocks : a list of phandle + clock-specifier pairs, one for each
>   	entry in clock-names
> - - clock-names : must be
> -	"sys_ck": for clock of xHCI MAC
> -	"ref_ck": for reference clock of xHCI MAC
> + - clock-names : must contain "sys_ck", and the following ones are optional:
> +	"ref_ck", "mcu_ck" and "dma_ck"
>   
>   Optional properties:
>    - vbus-supply : reference to the VBUS regulator;
>