linux-kernel - [PATCH v2 1/2] block: Treat all read ops as synchronous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171013034507.30823-1-jeffy.chen@rock-chips.com>
Date:   Fri, 13 Oct 2017 11:45:06 +0800
From:   Jeffy Chen <jeffy.chen@...k-chips.com>
To:     linux-kernel@...r.kernel.org, axboe@...com, hch@....de
Cc:     Jeffy Chen <jeffy.chen@...k-chips.com>,
        Shaun Tancheff <shaun.tancheff@...gate.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        NeilBrown <neilb@...e.com>, Jens Axboe <axboe@...nel.dk>,
        Shaohua Li <shli@...com>, Omar Sandoval <osandov@...com>
Subject: [PATCH v2 1/2] block: Treat all read ops as synchronous

The comment for op_is_sync() says "Reads are always treated as
synchronous", but it only checks for REQ_OP_READ.

Use op_is_write() to detect read ops and treat them as synchronous.

Fixes: aebf526b53ae ("block: fold cmd_type into the REQ_OP_ space")
Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
---

Changes in v2:
Rewrite commit message.

 include/linux/blk_types.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 3385c89f402e..b6a71c2eec36 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -288,8 +288,7 @@ static inline bool op_is_flush(unsigned int op)
  */
 static inline bool op_is_sync(unsigned int op)
 {
-	return (op & REQ_OP_MASK) == REQ_OP_READ ||
-		(op & (REQ_SYNC | REQ_FUA | REQ_PREFLUSH));
+	return !op_is_write(op) || (op & (REQ_SYNC | REQ_FUA | REQ_PREFLUSH));
 }
 
 typedef unsigned int blk_qc_t;
-- 
2.11.0