lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Oct 2017 17:59:00 +0000 From: <Woojung.Huh@...rochip.com> To: <vivien.didelot@...oirfairelinux.com>, <David.Laight@...LAB.COM>, <netdev@...r.kernel.org> CC: <linux-kernel@...r.kernel.org>, <kernel@...oirfairelinux.com>, <davem@...emloft.net>, <f.fainelli@...il.com>, <andrew@...n.ch> Subject: RE: [PATCH net-next v2 2/4] net: dsa: mv88e6060: setup random mac address Hi Vivien, > >> > + REG_WRITE(REG_GLOBAL, GLOBAL_MAC_01, (addr[0] << 9) | > >> addr[1]); > >> > >> Is that supposed to be 9 ? > > > > Looks like it. > > Check > http://www.marvell.com/switching/assets/marvell_linkstreet_88E6060_data > sheet.pdf > > Hum, David is correct, there is a bug in the driver which needs to be > addressed first. MAC address bit 40 is addr[0] & 0x1, thus we must > shift byte 0 by 8 and mask it against 0xfe. > > I'll respin this serie including a fix for both net and net-next. Yes, you are right. Missed description about bit 40. Thanks. Woojung
Powered by blists - more mailing lists