linux-kernel - Re: [PATCH 3/3] arm64: cpuinfo: display product info in /proc/cpuinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOZdJXWok=kHsLQLqf9sWiPibnhjnJptAteWoOA57ddEacniRg@mail.gmail.com>
Date:   Fri, 13 Oct 2017 14:27:33 -0500
From:   Timur Tabi <timur@...eaurora.org>
To:     Al Stone <ahs3@...hat.com>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Suzuki K Poulose <suzuki.poulose@....com>
Subject: Re: [PATCH 3/3] arm64: cpuinfo: display product info in /proc/cpuinfo

On Tue, Sep 26, 2017 at 5:23 PM, Al Stone <ahs3@...hat.com> wrote:
> +               if (IS_ENABLED(CONFIG_DMI)) {
> +                       seq_puts(m, "product name\t: ");
> +
> +                       if (!dmi_product_info)
> +                               get_dmi_product_info();
> +                       if (dmi_product_info)
> +                               seq_printf(m, "%s", dmi_product_info);

This line prints out like this:

product name    : QUALCOMM BASEBOARD ASSEMBLY, AMBERWIN
 20-P7989-H1S   , ARM 8.0 (r0p0) CPU @ 2.500GHz

Is this a bug in our DMI table?  'dmidecode' reports this:

Handle 0x0004, DMI type 2, 17 bytes
Base Board Information
        Manufacturer: QUALCOMM
        Product Name: BASEBOARD ASSEMBLY, AMBERWIN..
        Version: 20-P7989-H1S

I'm guessing that the actual string has a CR/LF at the end of "AMBERWIN"

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.