linux-kernel - Re: [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171013200943.qjyyjxuo54b4jgnu@rob-hp-laptop>
Date:   Fri, 13 Oct 2017 15:09:43 -0500
From:   Rob Herring <robh@...nel.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Chaotian Jing <chaotian.jing@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        yong mao <yong.mao@...iatek.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Phong LE <ple@...libre.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-mediatek@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        srv_heupstream <srv_heupstream@...iatek.com>
Subject: Re: [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit

On Tue, Oct 10, 2017 at 09:19:14AM +0200, Ulf Hansson wrote:
> On 10 October 2017 at 03:37, Chaotian Jing <chaotian.jing@...iatek.com> wrote:
> > On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote:
> >>
> >> On 10/09/2017 01:35 PM, Chaotian Jing wrote:
> >> > the driver has updated to have an explicit compatible, so update
> >> > binding file according to the driver change.
> >> >
> >> > Signed-off-by: Chaotian Jing <chaotian.jing@...iatek.com>
> >> > ---
> >> >   Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++--
> >> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> >> > index 3e0a97c..2bb585b 100644
> >> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> >> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> >> > @@ -8,8 +8,8 @@ and the properties used by the msdc driver.
> >> >
> >> >   Required properties:
> >> >   - compatible: value should be either of the following.
> >> > -   "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
> >> > -   "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173
> >> > +   "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
> >> > +   "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
> >>
> >> You can merge this with patch 1.
> >
> > OK, will merge it in next patch.
> 
> No, please don't!
> 
> I would like DT documentation changes to be posted in separate
> patches. Moreover, those should be before driver changes, when you
> order the changes in your series.
> 
> In this way, the bindings can be reviewed and acked separately, which
> makes it more convenient.

Yes. Also, it is step 2 in 
Documentation/devicetree/bindings/submitting-patches.txt.

Rob