linux-kernel - Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171014111153.GA50635@bfoster.bfoster>
Date:   Sat, 14 Oct 2017 07:11:54 -0400
From:   Brian Foster <bfoster@...hat.com>
To:     Dave Chinner <david@...morbit.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        linux-xfs@...r.kernel.org, Carlos Maiolino <cmaiolino@...hat.com>,
        Dave Chinner <dchinner@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: move two more RT specific functions into
 CONFIG_XFS_RT

On Sat, Oct 14, 2017 at 09:08:25AM +1100, Dave Chinner wrote:
> On Fri, Oct 13, 2017 at 02:05:40PM +0200, Arnd Bergmann wrote:
> > The last cleanup introduced two harmless warnings:
> > 
> > fs/xfs/xfs_fsmap.c:480:1: warning: '__xfs_getfsmap_rtdev' defined but not used
> > fs/xfs/xfs_fsmap.c:372:1: warning: 'xfs_getfsmap_rtdev_rtbitmap_helper' defined but not used
> > 
> > This moves those two functions as well.
> 
> Curious. I didn't get those warnings on gcc 6.4 or 7.2 on x86-64.
> 
> Oh, CONFIG_XFS_DEBUG=y hides them, because it removes the "static"
> declaration from them. Ok, that makes sense - I almost never build
> a non-debug kernel. Have to make sure when I do config changes next
> time to build without debug...
> 

Ah, that explains why I didn't reproduce them either, thanks!

Brian

> Thanks, Arnd!
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@...morbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html