linux-kernel - Re: [PATCH v5 0/3] i2c: Hookup typec power-negotation to the PMIC and charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 14 Oct 2017 14:04:11 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        "Krogerus, Heikki" <heikki.krogerus@...ux.intel.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v5 0/3] i2c: Hookup typec power-negotation to the PMIC and
 charger

Hi,

On 14-10-17 12:45, Andy Shevchenko wrote:
> On Wed, Oct 11, 2017 at 12:41 PM, Hans de Goede <hdegoede@...hat.com> wrote:
>> Hi All,
>>
>> These are the last 3 patches from all my work to add support for
>> USB PD charging to Intel Cherry Trail devices with a Whiskey Cove PMIC
>> and fusb302 Type-C controller.
>>
>> With these 3 patches these devices change from slowly discharging
>> at 5V 0.5A to actually charging at 12V 2A, so getting these upstream
>> is important for users of these devices.
>>
>> Wolfram does not really have time to review the first 2 patches, so if
>> someone else (from the people in the Cc) can review the first 2 patches
>> and esp. the first patch, so that we can get this merged for 4.15, then
>> that would be great.
> 
> The person comes to my mind is Heikki,
> Though I dunno he has time either.

The first patch, although it is an i2c-core change, is really
quite simple. I believe anyone can review it. But it does need
someone other then me to take a proper look (and not just do
a code only review) because it is a core change. Maybe there
is another way to solve the problem (persistent / predictable
device-names for i2c devices instantiated through board-data),
but I don't think so.

Also note this is all kernel internal stuff, so we can always
change it later. Although it would be better to get it right in
one go.

Regards,

Hans