linux-kernel - Re: [PATCH] iio: sw_device: make the function argument as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 14 Oct 2017 19:21:16 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: sw_device: make the function argument as const

On Wed, 11 Oct 2017 16:05:47 +0200
Bhumika Goyal <bhumirks@...il.com> wrote:

> This is a follow-up patch for:
> https://patchwork.kernel.org/patch/9999649/
> 
> Make the argument of the function iio_swd_group_init_type_name const as
> it is only passed to the function config_group_init_type_name having the
> argument as const.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

As mentioned before, please put together a single series with the
dependencies and the patches making use of them.

Otherwise, this is going to take a long time to merge.

Jonathan

> ---
> This change allows a lot of config_item_type structures to be const.
> 
>  include/linux/iio/sw_device.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iio/sw_device.h b/include/linux/iio/sw_device.h
> index fa79319..8642b91 100644
> --- a/include/linux/iio/sw_device.h
> +++ b/include/linux/iio/sw_device.h
> @@ -60,7 +60,7 @@ struct iio_sw_device *to_iio_sw_device(struct config_item *item)
>  static inline
>  void iio_swd_group_init_type_name(struct iio_sw_device *d,
>  				  const char *name,
> -				  struct config_item_type *type)
> +				  const struct config_item_type *type)
>  {
>  #if IS_ENABLED(CONFIG_CONFIGFS_FS)
>  	config_group_init_type_name(&d->group, name, type);