linux-kernel - Re: [PATCH] eCryptfs: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <654de3f9-ad17-983b-43e9-8556ebaf500b@canonical.com>
Date:   Fri, 13 Oct 2017 21:27:06 -0400
From:   Tyler Hicks <tyhicks@...onical.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, viro@...iv.linux.org.uk
Cc:     ecryptfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eCryptfs: constify attribute_group structures.

Hi Arvind - My apologies for the extremely slow review.

On 06/30/2017 05:33 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    6122	    636	     24	   6782	   1a7e	fs/ecryptfs/main.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    6186	    604	     24	   6814	   1a9e	fs/ecryptfs/main.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

This patch looks good. I'll get it queued up for 4.15.

Tyler

> ---
>  fs/ecryptfs/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> index 9014479..eea4c0f 100644
> --- a/fs/ecryptfs/main.c
> +++ b/fs/ecryptfs/main.c
> @@ -782,7 +782,7 @@ static ssize_t version_show(struct kobject *kobj,
>  	NULL,
>  };
>  
> -static struct attribute_group attr_group = {
> +static const struct attribute_group attr_group = {
>  	.attrs = attributes,
>  };
>  
> 




Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)