| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <59e1a9b1.bvX01JHa+mut7wXC%fengguang.wu@intel.com>
Date: Sat, 14 Oct 2017 14:07:45 +0800
From: kernel test robot <fengguang.wu@...el.com>
To: Lucas Stach <l.stach@...gutronix.de>
Cc: LKP <lkp@...org>, linux-kernel@...r.kernel.org,
linux-spi@...r.kernel.org, Mark Brown <broonie@...nel.org>,
wfg@...ux.intel.com
Subject: 9ce70d49fa ("spi: fix IDR collision on systems with both fixed
.."): WARNING: CPU: 1 PID: 1 at include/linux/idr.h:113
spi_register_controller
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git fix/core
commit 9ce70d49fa80b95a029c16432270f4edbbd2a953
Author: Lucas Stach <l.stach@...gutronix.de>
AuthorDate: Fri Oct 13 17:59:46 2017 +0200
Commit: Mark Brown <broonie@...nel.org>
CommitDate: Fri Oct 13 17:43:27 2017 +0100
spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers
On systems where some controllers get a dynamic ID assigned and some have
a fixed number from DT, the current implemention might run into an IDR
collision if the dynamic controllers gets probed first and get an IDR number,
which is later requested by the controller with the fixed numbering. When
this happens the fixed controller will fail to register with the SPI core.
Fix this by skipping all known alias numbers when assigning the dynamic IDs.
Fixes: 9b61e302210e (spi: Pick spi bus number from Linux idr or spi alias)
Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
Signed-off-by: Mark Brown <broonie@...nel.org>
2bd6bf03f4 Linux 4.14-rc1
9ce70d49fa spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers
9ce70d49fa spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers
+---------------------------------------------------------+-----------+------------+------------+
| | v4.14-rc1 | 9ce70d49fa | 9ce70d49fa |
+---------------------------------------------------------+-----------+------------+------------+
| boot_successes | 56 | 0 | 0 |
| boot_failures | 0 | 52 | 52 |
| WARNING:at_include/linux/idr.h:#spi_register_controller | 0 | 52 | 52 |
| WARNING:at_drivers/spi/spi.c:#spi_register_controller | 0 | 52 | 52 |
| WARNING:at_lib/kobject.c:#kobject_add_internal | 0 | 52 | 52 |
+---------------------------------------------------------+-----------+------------+------------+
[ 31.566884] usbcore: registered new interface driver dln2
[ 31.567675] Uniform Multi-Platform E-IDE driver
[ 31.568897] ide_generic: please use "probe_mask=0x3f" module parameter for probing all legacy ISA IDE ports
[ 31.570356] ide-gd driver 1.18
[ 31.594454] ------------[ cut here ]------------
[ 31.595244] WARNING: CPU: 1 PID: 1 at include/linux/idr.h:113 spi_register_controller+0x539/0x560
[ 31.596900] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.14.0-rc1-00001-g9ce70d49 #1
[ 31.597991] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014
[ 31.599570] task: ffff99e1dd11d000 task.stack: ffff99e1dd114000
[ 31.600735] RIP: 0010:spi_register_controller+0x539/0x560
[ 31.601561] RSP: 0000:ffff99e1dd117d60 EFLAGS: 00010246
[ 31.602300] RAX: 0000000000000000 RBX: ffff99e1dd3c2800 RCX: 0000000000000d89
[ 31.603394] RDX: ffff99e1de40dc80 RSI: 0000000000000000 RDI: 0000000000000286
[ 31.605906] RBP: ffff99e1d6f5a000 R08: 0000000000000000 R09: 0000000000000001
[ 31.606929] R10: ffff99e1dd117d60 R11: 0000000000000000 R12: ffff99e1d6f5a000
[ 31.607985] R13: ffff99e1d6b0a000 R14: 0000000000000000 R15: 4a01b6fc37876693
[ 31.609091] FS: 0000000000000000(0000) GS:ffff99e1de400000(0000) knlGS:0000000000000000
[ 31.615417] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 31.616266] CR2: 00000000ffffffff CR3: 000000000ac11000 CR4: 00000000000006e0
[ 31.618220] Call Trace:
[ 31.618638] ? refcount_inc+0x11/0x50
[ 31.619190] ? spi_bitbang_start+0xe4/0x1b0
[ 31.619778] ? spi_lm70llp_attach+0xfe/0x360
[ 31.623582] ? attach_driver_chain+0x60/0x60
[ 31.624181] ? port_check+0x2d/0x40
[ 31.624695] ? bus_for_each_dev+0x92/0xe0
[ 31.625279] ? __parport_register_driver+0x157/0x160
[ 31.625987] ? dw_spi_driver_init+0x49/0x49
[ 31.626576] ? do_one_initcall+0xe0/0x2bd
[ 31.627113] ? kernel_init_freeable+0x294/0x3c0
[ 31.636918] ? rest_init+0x160/0x160
[ 31.637574] ? kernel_init+0xf/0x169
[ 31.638174] ? rest_init+0x160/0x160
[ 31.638799] ? rest_init+0x160/0x160
[ 31.639401] ? ret_from_fork+0x25/0x30
[ 31.640030] Code: 48 89 ef e8 9a 26 f4 ff e9 43 ff ff ff 41 bc ed ff ff ff e9 2b fd ff ff e8 f5 30 85 ff 31 f6 48 c7 c7 c0 74 8d 95 e8 f7 47 75 00 <0f> ff 48 c7 c7 c0 74 8d 95 e8 39 47 75 00 48 c7 c7 9c 8a 68 95
[ 31.643275] ---[ end trace df64f0f369d434fe ]---
[ 31.644102] couldn't get idr
# HH:MM RESULT GOOD BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start acb325accc41652d809e7efa3a02620fc91e9515 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f --
git bisect bad 8ffaff92273be539472fb417f9ed66fadcb8029a # 08:09 B 0 10 22 0 Merge 'jpoimboe/orc-default' into devel-spot-201710140421
git bisect bad 228f85fc08150a8ac0e5aaf717db28a8a35d685e # 08:21 B 0 11 23 0 Merge 'nfsd/master' into devel-spot-201710140421
git bisect good ea05a66ac0fdad8358d5a03363af0794510d4e81 # 08:40 G 11 0 0 0 Merge 'linux-review/Roman-Mashak/bridge-return-error-code-when-deleting-Vlan/20171014-024422' into devel-spot-201710140421
git bisect good b5c639a86d37266ff4215f58d38182628cd06a96 # 08:56 G 11 0 0 0 Merge 'kdave-btrfs-devel/ext/josef/queue' into devel-spot-201710140421
git bisect good 2932a42ad55a2424df27e55a4f9d1ebecc84ac44 # 09:13 G 11 0 0 0 Merge 'net-next/master' into devel-spot-201710140421
git bisect bad ef43d04e04b9b9a39882d97e3ad3e152cee445b5 # 09:26 B 0 10 22 0 Merge 'spi/for-next' into devel-spot-201710140421
git bisect good 5a866ec0014b2baa4ecbb1eaa19c835482829d08 # 09:39 G 11 0 0 0 spi: a3700: Return correct value on timeout detection
git bisect bad 04d6089edc878ae19d55f33ebb5c8c21cfc0210d # 10:34 B 0 11 25 2 Merge remote-tracking branch 'spi/fix/core' into spi-linus
git bisect bad 9ce70d49fa80b95a029c16432270f4edbbd2a953 # 10:53 B 0 11 23 0 spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers
# first bad commit: [9ce70d49fa80b95a029c16432270f4edbbd2a953] spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers
git bisect good 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e # 13:40 G 32 0 0 0 Linux 4.14-rc1
# extra tests with CONFIG_DEBUG_INFO_REDUCED
git bisect bad 9ce70d49fa80b95a029c16432270f4edbbd2a953 # 13:40 B 0 8 20 0 spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers
# extra tests on HEAD of linux-devel/devel-spot-201710140421
git bisect bad acb325accc41652d809e7efa3a02620fc91e9515 # 13:45 B 0 35 50 0 0day head guard for 'devel-spot-201710140421'
# extra tests on tree/branch spi/fix/core
git bisect bad 9ce70d49fa80b95a029c16432270f4edbbd2a953 # 13:51 B 0 52 64 0 spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers
# extra tests with first bad commit reverted
git bisect good b2f1e295e38fc6c3d4c36798849c1fdf0ca38231 # 14:06 G 11 0 0 0 Revert "spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers"
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/lkp Intel Corporation
Download attachment "dmesg-quantal-intel12-10:20171014131949:x86_64-randconfig-r0-10140658:4.14.0-rc1-00001-g9ce70d49:1.gz" of type "application/gzip" (49414 bytes)
View attachment "reproduce-quantal-intel12-10:20171014131949:x86_64-randconfig-r0-10140658:4.14.0-rc1-00001-g9ce70d49:1" of type "text/plain" (888 bytes)
View attachment "config-4.14.0-rc1-00001-g9ce70d49" of type "text/plain" (111085 bytes)
Powered by blists - more mailing lists