linux-kernel - Re: [PATCH] Makefile: Another fix for stackprotector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87376kok6g.fsf@belgarion.home>
Date:   Sun, 15 Oct 2017 11:05:27 +0200
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Makefile: Another fix for stackprotector _AUTO mode

Kees Cook <keescook@...omium.org> writes:

> If the compiler didn't support a build mode, the second empty test would
> still trip. This moves it to an "else" test for the non-AUTO modes.
>
> Reported-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> Robert, can you test this fix?
Sure, tested and it works perfectly.

Tested-by: Robert Jarzmik <robert.jarzmik@...e.fr>

And just to be more complete, what happened yesterday was that I wrongly wrote
"CROSS_COMPILER=arm-linux-gnueabi-" and not "CROSS_COMPILE=arm-linux-gnueabi-".

Normally when I do that kind of mistake, I get a gcc error that my architecture
options (-mabi, ...) are not supported. This time I got the stackprotector
thing. The good part is that with your patch I see again the gcc warnings I was
used too :)

Cheers.

--
Robert

PS:
rj@...garion:~/mio_linux/kernel$ arm-linux-gnueabi-gcc -fstack-protector
arm-linux-gnueabi-gcc: fatal error: no input files
compilation terminated.