linux-kernel - Re: [PATCH] video: fbdev: Fix an errro handling path in 'au1200fb_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <197e2a4e-bfc9-c0d5-11fc-c071be0c18b3@wanadoo.fr>
Date:   Sun, 15 Oct 2017 16:26:25 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     tj@...nel.org, viro@...iv.linux.org.uk,
        linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] video: fbdev: Fix an errro handling path in
 'au1200fb_drv_probe()'

Le 12/10/2017 à 18:25, Bartlomiej Zolnierkiewicz a écrit :
> [ added dri-devel ML to cc: ]
>
> On Tuesday, September 12, 2017 07:39:30 AM Christophe JAILLET wrote:
>> If 'dmam_alloc_attrs()' fails, we must go through the error handling code,
>> as done elsewhere in this function. Otherwise, there is a resource leak.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>> ---
>> I'm also puzzled by the 'framebuffer_alloc()' call a few lines above.
>> 'ret' is known to be 0 at this point. I guess that -ENOMEM should also be
>> returned.
> Yes, moreover the "failed:" error path is incomplete (please take
> a look at au1200fb_drv_remove() for comparison) and needs to be fixed.
>
> Could you please take care of it?

I will try, but be indulgent :)

My understanding of the code is that they are several issues all related 
to this error handling path (double free, missing memory release, 
invalid irq release...)
I will try to sort it out, but my first tries will likely be incomplete 
and/or broken.

CJ