linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: avoid stale fi->gdirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171016230626.GB94030@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Mon, 16 Oct 2017 16:06:26 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid stale fi->gdirty_list pointer

On 10/16, Chao Yu wrote:
> On 2017/10/13 10:14, Jaegeuk Kim wrote:
> > When doing fault injection test, f2fs_evict_inode() didn't remove gdirty_list
> > which incurs a kernel panic due to wrong pointer access.
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> 
> Reviewed-by: Chao Yu <yuchao0@...wei.com>
> 
> Minor thing, how about reverting judgment condition for readability?
> 
> if (is_set_ckpt_flags(sbi, CP_ERROR_FLAG))
> 	f2fs_inode_synced()

We don't need to expect such the errored corner case first. ;)

> else
> 	f2fs_bug_on()
> 
> Thanks,
> 
> > ---
> >  fs/f2fs/inode.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > index f6db9d533ca4..1ae5396c97d6 100644
> > --- a/fs/f2fs/inode.c
> > +++ b/fs/f2fs/inode.c
> > @@ -535,6 +535,8 @@ void f2fs_evict_inode(struct inode *inode)
> >  
> >  	if (!is_set_ckpt_flags(sbi, CP_ERROR_FLAG))
> >  		f2fs_bug_on(sbi, is_inode_flag_set(inode, FI_DIRTY_INODE));
> > +	else
> > +		f2fs_inode_synced(inode);
> >  
> >  	/* ino == 0, if f2fs_new_inode() was failed t*/
> >  	if (inode->i_ino)
> >