linux-kernel - Re: [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171016060510.GF30097@localhost>
Date:   Mon, 16 Oct 2017 11:35:10 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Chintan Patel <chintan.m.patel@...el.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Jeeja KP <jeeja.kp@...el.com>,
        "guneshwor.o.singh@...el.com" <guneshwor.o.singh@...el.com>,
        Shreyas NC <shreyas.nc@...el.com>,
        Takashi Sakamoto <takashi.sakamoto@...aclelinux.com>,
        Ramesh Babu <ramesh.babu@...el.com>,
        Dharageswari R <dharageswari.r@...el.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology
 loading

On Thu, Oct 12, 2017 at 09:44:37AM -0700, Chintan Patel wrote:
> In case of failure in loading customize topology firmware, dfw_sst.bin
> gets loaded. However, current log provides this message as error even
> after successfully falling back to default topology "dfw_sst.bin".
> 
> Hence to convey proper message, changing log level and message.

Acked-By: Vinod Koul <vinod.koul@...el.com>

> Signed-off-by: Chintan Patel <chintan.m.patel@...el.com>
> ---
> Changes in v2:
> Addressing review comments from Takashi Iwai by changing
> loglevel as info
> 
> sound/soc/intel/skylake/skl-topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
> index 22f768ca3c73..12f383fd7c39 100644
> --- a/sound/soc/intel/skylake/skl-topology.c
> +++ b/sound/soc/intel/skylake/skl-topology.c
> @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
>  
>  	ret = request_firmware(&fw, skl->tplg_name, bus->dev);
>  	if (ret < 0) {
> -		dev_err(bus->dev, "tplg fw %s load failed with %d\n",
> +		dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
>  				skl->tplg_name, ret);
>  		ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
>  		if (ret < 0) {
> -- 
> 1.9.1
> 

-- 
~Vinod