linux-kernel - RE: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F3B0350DF4CB6849A642218320DE483D7D662EA9@SHSMSX104.ccr.corp.intel.com>
Date:   Mon, 16 Oct 2017 06:04:14 +0000
From:   "Wang, Zhi A" <zhi.a.wang@...el.com>
To:     Christos Gkekas <chris.gekas@...il.com>,
        "Gao, Fred" <fred.gao@...el.com>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        David Airlie <airlied@...ux.ie>,
        "intel-gvt-dev@...ts.freedesktop.org" 
        <intel-gvt-dev@...ts.freedesktop.org>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm/i915/gvt: Fix error handling bug in
 perform_bb_shadow

Hi：
    Thanks for the patch. This problem has been fixed on staging branch with:

a8e18bfc854141621a29600a6c13e5f40c6e9f19

drm/i915/gvt: Refine shadow batch buffer

Thanks,
Zhi.

-----Original Message-----
From: Christos Gkekas [mailto:chris.gekas@...il.com] 
Sent: Monday, October 16, 2017 1:18 AM
To: Gao, Fred <fred.gao@...el.com>; Zhenyu Wang <zhenyuw@...ux.intel.com>; Wang, Zhi A <zhi.a.wang@...el.com>; Jani Nikula <jani.nikula@...ux.intel.com>; Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@...el.com>; David Airlie <airlied@...ux.ie>; intel-gvt-dev@...ts.freedesktop.org; intel-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org
Cc: Christos Gkekas <chris.gekas@...il.com>
Subject: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow

Change the type of variable 'bb_size' from uint32_t to int to be able to hold error return values from find_bb_size(). This change seems to have been missed from previous commit 1e3197d6ad73.

Signed-off-by: Christos Gkekas <chris.gekas@...il.com>
---
 drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 2c0ccbb..f41cbf6 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s)
 	struct intel_shadow_bb_entry *entry_obj;
 	struct intel_vgpu *vgpu = s->vgpu;
 	unsigned long gma = 0;
-	uint32_t bb_size;
+	int bb_size;
 	void *dst = NULL;
 	int ret = 0;
 
--
2.7.4