linux-kernel - Re: [RFC 07/19] KVM: s390: introduce AP matrix configuration interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171016111030.1a955866@mschwideX1>
Date:   Mon, 16 Oct 2017 11:10:30 +0200
From:   Martin Schwidefsky <schwidefsky@...ibm.com>
To:     Tony Krowiak <akrowiak@...ux.vnet.ibm.com>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, freude@...ibm.com, heiko.carstens@...ibm.com,
        borntraeger@...ibm.com, cohuck@...hat.com, kwankhede@...dia.com,
        bjsdjshi@...ux.vnet.ibm.com, pbonzini@...hat.com,
        alex.williamson@...hat.com, pmorel@...ux.vnet.ibm.com,
        alifm@...ux.vnet.ibm.com, mjrosato@...ux.vnet.ibm.com,
        qemu-s390x@...gnu.org, jjherne@...ux.vnet.ibm.com,
        thuth@...hat.com, pasic@...ux.vnet.ibm.com
Subject: Re: [RFC 07/19] KVM: s390: introduce AP matrix configuration
 interface

On Fri, 13 Oct 2017 13:38:52 -0400
Tony Krowiak <akrowiak@...ux.vnet.ibm.com> wrote:

> This patch introduces a new compilation unit that will contain
> all of the data structures and logic for configuring AP adapters,
> usage domains and control domains for a KVM guest.
> 
> Signed-off-by: Tony Krowiak <akrowiak@...ux.vnet.ibm.com>
> ---
>  MAINTAINERS                       |    2 ++
>  arch/s390/include/asm/ap-config.h |   12 ++++++++++++
>  arch/s390/kvm/Makefile            |    2 +-
>  arch/s390/kvm/ap-config.c         |    9 +++++++++
>  4 files changed, 24 insertions(+), 1 deletions(-)
>  create mode 100644 arch/s390/include/asm/ap-config.h
>  create mode 100644 arch/s390/kvm/ap-config.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0c8855a..4de0904 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11721,6 +11721,8 @@ F:	drivers/s390/crypto/ap_matrix_bus.c
>  F:	drivers/s390/crypto/vfio_ap_matrix_drv.c
>  F:	drivers/s390/crypto/vfio_ap_matrix_private.h
>  F:	drivers/s390/crypto/vfio_ap_matrix_ops.c
> +F:	arch/s390/include/asm/kvm/ap-config.h
> +F:	arch/s390/kvm/ap-config.c
> 
>  S390 ZFCP DRIVER
>  M:	Steffen Maier <maier@...ux.vnet.ibm.com>
> diff --git a/arch/s390/include/asm/ap-config.h b/arch/s390/include/asm/ap-config.h
> new file mode 100644
> index 0000000..8491b5f
> --- /dev/null
> +++ b/arch/s390/include/asm/ap-config.h
> @@ -0,0 +1,12 @@
> +/*
> + * Adjunct Processor (AP) configuration management for KVM guests
> + *
> + * Copyright IBM Corp. 2017
> + *
> + * Author(s): Tony Krowiak <akrowia@...ux.vnet.ibm.com>
> + */
> +
> +#ifndef _ASM_KVM_AP_CONFIG_H_
> +#define _ASM_KVM_AP_CONFIG_H_
> +
> +#endif /* _ASM_KVM_AP_CONFIG_H_ */
> diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile
> index 09a9e6d..0397b9c 100644
> --- a/arch/s390/kvm/Makefile
> +++ b/arch/s390/kvm/Makefile
> @@ -12,6 +12,6 @@ common-objs = $(KVM)/kvm_main.o $(KVM)/eventfd.o  $(KVM)/async_pf.o $(KVM)/irqch
>  ccflags-y := -Ivirt/kvm -Iarch/s390/kvm
> 
>  kvm-objs := $(common-objs) kvm-s390.o intercept.o interrupt.o priv.o sigp.o
> -kvm-objs += diag.o gaccess.o guestdbg.o sthyi.o vsie.o
> +kvm-objs += diag.o gaccess.o guestdbg.o sthyi.o vsie.o ap-config.o
> 
>  obj-$(CONFIG_KVM) += kvm.o
> diff --git a/arch/s390/kvm/ap-config.c b/arch/s390/kvm/ap-config.c
> new file mode 100644
> index 0000000..84fdf43
> --- /dev/null
> +++ b/arch/s390/kvm/ap-config.c
> @@ -0,0 +1,9 @@
> +/*
> + * Adjunct Processor (AP) configuration management for KVM guests
> + *
> + * Copyright IBM Corp. 2017
> + *
> + * Author(s): Tony Krowiak <akrowia@...ux.vnet.ibm.com>
> + */
> +
> +#include <asm/ap-config.h>

Another patch that introduces empty files. Please don't do that. Merge
patch #7 with patch #16. With the dependency in patch #8 on the ap-config.h
header the new place for the combined patch would be prior to patch #8.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.