linux-kernel - Re: [PATCH 2/2] vfio: ccw: validate the count field of a ccw before pinning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171016111420.4a8ca1af.cohuck@redhat.com>
Date:   Mon, 16 Oct 2017 11:14:20 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     Dong Jia Shi <bjsdjshi@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        kvm@...r.kernel.org, borntraeger@...ibm.com,
        pasic@...ux.vnet.ibm.com, pmorel@...ux.vnet.ibm.com
Subject: Re: [PATCH 2/2] vfio: ccw: validate the count field of a ccw before
 pinning

On Wed, 11 Oct 2017 04:38:22 +0200
Dong Jia Shi <bjsdjshi@...ux.vnet.ibm.com> wrote:

> If the count field of a ccw is zero, there is no need to
> try to pin page(s) for it. Let's check the count value
> before starting pinning operations.
> 
> Reviewed-by: Pierre Morel <pmorel@...ux.vnet.ibm.com>
> Signed-off-by: Dong Jia Shi <bjsdjshi@...ux.vnet.ibm.com>
> ---
>  drivers/s390/cio/vfio_ccw_cp.c | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)

This sounds reasonable, and I could not spot anything in the
architecture that speaks against simply setting the IDA flag. Hopefully
there's nothing buried out of sight :)