linux-kernel - Re: [RESEND PATCH v2 4/5] drm/bridge/analogix: Do not use device's drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 12:44:09 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>,
        linux-kernel@...r.kernel.org
Cc:     dmitry.torokhov@...il.com, heiko@...ech.de,
        briannorris@...omium.org, rjw@...ysocki.net, dianders@...omium.org,
        tfiga@...omium.org, broonie@...nel.org, seanpaul@...omium.org,
        dri-devel@...ts.freedesktop.org, Caesar Wang <wxt@...k-chips.com>,
        David Airlie <airlied@...ux.ie>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        linux-samsung-soc@...r.kernel.org,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        Inki Dae <inki.dae@...sung.com>,
        linux-rockchip@...ts.infradead.org,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Kukjin Kim <kgene@...nel.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        zain wang <wzz@...k-chips.com>,
        Archit Taneja <architt@...eaurora.org>,
        Joonyoung Shim <jy0922.shim@...sung.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Mark Yao <mark.yao@...k-chips.com>,
        Jingoo Han <jingoohan1@...il.com>
Subject: Re: [RESEND PATCH v2 4/5] drm/bridge/analogix: Do not use device's
 drvdata

On 16.10.2017 12:06, Jeffy Chen wrote:
> From: Tomasz Figa <tfiga@...omium.org>
>
> The driver that instantiates the bridge should own the drvdata, as all
> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
> owned by its driver struct. Moreover, storing two different pointer
> types in driver data depending on driver initialization status is barely
> a good practice and in fact has led to many bugs in this driver.
>
> Let's clean up this mess and change Analogix entry points to simply
> accept some opaque struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
>
> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>

Thanks for making it a bit saner.

Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

 --
Regards
Andrzej