linux-kernel - Re: [PATCH] ASoC: sgtl5000: add support for a fixed sysclk frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9A3652B7-C0ED-44DE-AC6F-9D883076E9B8@theobroma-systems.com>
Date:   Mon, 16 Oct 2017 13:17:07 +0200
From:   Jakob Unterwurzacher <jakob.unterwurzacher@...obroma-systems.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Fabio Estevam <fabio.estevam@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Klaus Goger <klaus.goger@...obroma-systems.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Richard Leitner <richard.leitner@...data.com>,
        Bhumika Goyal <bhumirks@...il.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] ASoC: sgtl5000: add support for a fixed sysclk frequency


> On 16. Oct 2017, at 12:51, Fabio Estevam <festevam@...il.com> wrote:
> 
> Hi Jakob,
> 
> On Mon, Oct 16, 2017 at 7:46 AM, Jakob Unterwurzacher
> <jakob.unterwurzacher@...obroma-systems.com> wrote:
>> Hi Fabio, that’s interesting.
>> 
>> Looks like the fsl,imx-audio-sgtl5000 sound card driver that is used on the imx51-babbage
>> does not try to adjust MCLK in response to the playback sample rate.
>> 
>> The simple-audio-card driver does that (it calls snd_soc_dai_set_sysclk whenever playback
>> starts).
> 
> Could you please test this with linux-next tree?
> 
> Looks like that the recent b0a7043d5c2c("ASoC: fsl_ssi: Caculate bit
> clock rate using slot number and width") would avoid the issue.
> 

Hi Fabio,

if this ( https://patchwork.kernel.org/patch/9952385/ ) is the patch, then it seems to be
specific to the Freescale I2S controller. We use the SGTL5000 together with a Rockchip CPU.

I think I see a way to fix this without adding a DTS property, I’ll send out a patch later this afternoon.

Best regards,
Jakob