linux-kernel - Re: [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171016120633.6jof6wvsre27rxhv@flea.lan>
Date:   Mon, 16 Oct 2017 14:06:33 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     icenowy@...c.io
Cc:     devicetree@...r.kernel.org, linux-sunxi@...glegroups.com,
        linux-kernel@...r.kernel.org, Chen-Yu Tsai <wens@...e.org>,
        Icenowy Zheng <icenowy@...c.xyz>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40

On Mon, Oct 16, 2017 at 05:39:58PM +0800, icenowy@...c.io wrote:
> 在 2017-10-16 17:32，Maxime Ripard 写道：
> > On Tue, Oct 10, 2017 at 07:24:28AM +0800, Icenowy Zheng wrote:
> > > >> +			interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> > > >> +			clocks = <&ccu CLK_BUS_OHCI1>,
> > > >> +				 <&ccu CLK_BUS_EHCI1>,
> > > >> +				 <&ccu CLK_USB_OHCI1>;
> > > >> +			resets = <&ccu RST_BUS_OHCI1>,
> > > >> +				 <&ccu RST_BUS_EHCI1>;
> > > >
> > > >Why do you need to take the OHCI resources too?
> > > 
> > > AW's strange design -- without OHCI resources taken EHCI
> > > won't work.
> > 
> > How has this been tested?
> 
> As EHCI is probed before OHCI, this behavior is easy to
> appear if the OHCI resources are removed.

And what is "this behaviour" exactly?

What have you tested, what device did you connect, what is the outcome
that isn't something you expected, etc.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)