linux-kernel - Re: [PATCH 0/2] fix lockdep warnings in s5p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <c2dae5ff-a35c-bdd1-910b-75db6c9c16b2@samsung.com>
Date:   Mon, 16 Oct 2017 14:48:54 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Shuah Khan <shuahkh@....samsung.com>, mchehab@...nel.org,
        hansverk@...co.com, kgene@...nel.org, krzk@...nel.org,
        s.nawrocki@...sung.com, shailendra.v@...sung.com, shuah@...nel.org,
        Julia.Lawall@...6.fr, kyungmin.park@...sung.com, kamil@...as.org,
        jtp.park@...sung.com, a.hajda@...sung.com
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2
 drivers

Hi Shuah,

On 2017-10-14 01:13, Shuah Khan wrote:
> Driver mmap functions shouldn't hold lock when calling vb2_mmap(). The
> vb2_mmap() function has its own lock that it uses to protect the critical
> section.
>
> Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3

It would make sense to add the information about the reference commit to 
each
commit message and also point to commit 
e752577ed7bf55c81e10343fced8b378cda2b63b,
as it is exactly the same case here. Anyway:

Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>

I wonder if makes sense to send those patches also to stable@...t.kernel.org
(maybe v4.3+, like the mentioned above commit, if they really apply?).

> Shuah Khan (2):
>    media: exynos-gsc: fix lockdep warning
>    media: s5p-mfc: fix lockdep warning
>
>   drivers/media/platform/exynos-gsc/gsc-m2m.c | 5 -----
>   drivers/media/platform/s5p-mfc/s5p_mfc.c    | 3 ---
>   2 files changed, 8 deletions(-)
>

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland